Conversation
Collaborator
Author
|
This PR is broken, because I accidentally started pushing commits to it instead of a new branch to fix #179. I'll continue here so the PR will be much larger. |
…950 VCCB in elements so maybe missing?
meme pvs are not complete e.g. OTRS:DIAG0:420 does not have any of the PVs that are in our list. Also ACCL:L2B:0910:PDES was missing. Devices missing from lcls_elements.csv in lcls-tools and lcls-lattice e.g. vcc and vccb
robnagler
requested review from
moellep
and removed request for
eloise-nebula
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #180